Project

General

Profile

Actions
Copy link

Issue #1179

closed
RS PK

project external/google contains analytics and market related stuff

Issue #1179: project external/google contains analytics and market related stuff

Added by Robert Schultz over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Paul Kocialkowski
Category:
-
Target version:
Replicant 4.2
Start date:
01/15/2015
Due date:
% Done:

0%

Estimated time:
Resolution:
fixed
Device:
Grant:
Type of work:

Description

In the manifest's default.xml contains <project path="external/google" name="CyanogenMod/android_external_google" />. This folder contains jar files from play, gcm, admob, market_licensing etc. Just wondering if this is removable to make it clean and lean! Or perhaps it does not matter?
Great work!

RS Updated by Robert Schultz over 11 years ago Actions
Copy link
 #1

I meant "great work" not as a sarcasm. Truly, I appreciate replicant :-)

DK Updated by Daniel Kulesz over 11 years ago Actions
Copy link
 #2

You are refering to line 261 in the current default.xml of the 4.2 branch, right? I see the entry there as well.

Did you try to drop it and recompile without it?

PK Updated by Paul Kocialkowski over 11 years ago Actions
Copy link
 #3

Did you try to drop it and recompile without it?

I just did, it apparently works fine.

PK Updated by Paul Kocialkowski over 11 years ago Actions
Copy link
 #4

I'll build all the targets on the builder and see if it affects any.

PK Updated by Paul Kocialkowski over 11 years ago Actions
Copy link
 #5

  • Status changed from New to Closed
  • Resolution set to fixed

Everything builds fine, this was not necessary nor included. I didn't look in-depth, but there may have been proprietary components in there. Manifest commit: https://gitorious.org/replicant/manifest/commit/d921ee65af81d266fefc6cfa146c74f488208bcf

Thanks for the report!

Actions
Copy link

Also available in: PDF Atom